fix(rpc/errorToObject): return null when error not present

CheerlessCloud · Sep 28, 2018 · 920ad4f · 920ad4f
1 parent 60005b6
commit 920ad4f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/src/rpc/errorToObject.js b/src/rpc/errorToObject.js
@@ -1,11 +1,11 @@
 // @flow
-export default function errorToObject(error: ?Error): void | Object {
+export default function errorToObject(error: ?Error): null | Object {
   const errorObj = {};
 
   if (error === undefined) {
-    return undefined;
+    return null;
   } else if (error === null) {
-    return undefined;
+    return null;
   }
 
   Object.getOwnPropertyNames(error).forEach(key => {

diff --git a/src/rpc/errorToObject.test.js b/src/rpc/errorToObject.test.js
@@ -4,11 +4,11 @@ import EError from 'eerror';
 import errorToObject from './errorToObject';
 
 test('call with undefined', t => {
-  t.is(errorToObject(undefined), undefined);
+  t.is(errorToObject(undefined), null);
 });
 
 test('call with null', t => {
-  t.is(errorToObject(null), undefined);
+  t.is(errorToObject(null), null);
 });
 
 test('call with eerror', t => {