Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display multi-month subscriptions properly. #2026

Open
dmatech1 opened this issue Oct 3, 2020 · 5 comments
Open

Display multi-month subscriptions properly. #2026

dmatech1 opened this issue Oct 3, 2020 · 5 comments
Labels
blocked Something out of our power needs to change before proceeding with this issue bug Something isn't working as intended, or works in a confusing/unintuitive way for the user Platform: Twitch

Comments

@dmatech1
Copy link

dmatech1 commented Oct 3, 2020

Describe the bug
Chatterino currently doesn't show how many months a multi-month subscription was for. It just shows the event like this:

18:15 dmabot subscribed at Tier 1. 

The actual IRC message has this information in the msg-param-multimonth-duration parameter:

@badge-info=subscriber/0;badges=moderator/1,subscriber/0,bits-leader/1;color=;display-name=dmabot;emotes=;flags=;id=7cd781c7-cf8e-4fbd-83a3-a1e3faefa8d1;login=dmabot;mod=1;msg-id=sub;msg-param-cumulative-months=1;msg-param-months=0;msg-param-multimonth-duration=3;msg-param-multimonth-tenure=0;msg-param-should-share-streak=0;msg-param-sub-plan-name=Channel\sSubscription\s(dmatech);msg-param-sub-plan=1000;msg-param-was-gifted=false;room-id=217476645;subscriber=1;system-msg=dmabot\ssubscribed\sat\sTier\s1.;tmi-sent-ts=1601676954267;user-id=421031430;user-type=mod :tmi.twitch.tv USERNOTICE #dmatech

To reproduce
Purchase a multi-month subscription.

Chatterino version
Chatterino 2.2.2 (commit 07fc0c3)

Operating system
Windows 10 Version 1909 (OS Build 18363.1082)

@dmatech1 dmatech1 added bug Something isn't working as intended, or works in a confusing/unintuitive way for the user needs triage labels Oct 3, 2020
@Mm2PL
Copy link
Collaborator

Mm2PL commented Oct 3, 2020

Pretty sure that isn't documented.

@dmatech1
Copy link
Author

dmatech1 commented Oct 4, 2020

Weird. I'd test it again myself but I'd rather not take up any more of my founder slots. Looks like Twitch Chat itself doesn't show the duration, and it doesn't seem to be in the chat log JSON at all.

@RAnders00
Copy link
Collaborator

RAnders00 commented Oct 4, 2020

This is something Twitch should fix. Chatterino just displays the system-msg:

system-msg=dmabot\ssubscribed\sat\sTier\s1

@pajlada pajlada added blocked Something out of our power needs to change before proceeding with this issue Platform: Twitch and removed needs triage labels Oct 4, 2020
@pajlada pajlada closed this as completed Oct 4, 2020
@zneix
Copy link
Collaborator

zneix commented Apr 21, 2021

I'll try to bother dankers @ twitch to document that, since I think it's worth adding this - noticed more examples of this in my own channel, e.g. the following (plain IRC message split by s/;/\r/g):

@badge-info=subscriber/0
badges=subscriber/0,premium/1
color=#0000FF
display-name=MirkovIV
emotes=
flags=
id=17d1ab74-0f2e-4727-880b-fe1e7a5c1a27
login=mirkoviv
mod=0
msg-id=sub
msg-param-cumulative-months=1
msg-param-months=0
msg-param-multimonth-duration=3
msg-param-multimonth-tenure=0
msg-param-should-share-streak=0
msg-param-sub-plan-name=awesome\ssub\sto\szneix\sKKona
msg-param-sub-plan=1000
msg-param-was-gifted=false
room-id=99631238
subscriber=1
system-msg=MirkovIV\ssubscribed\sat\sTier\s1.
tmi-sent-ts=1615843746781
user-id=70365426
user-type= :tmi.twitch.tv USERNOTICE #zneix

@zneix zneix self-assigned this Apr 21, 2021
@zneix
Copy link
Collaborator

zneix commented Apr 21, 2021

Opened a TwitchDev Forums:tm: ticket and got redirected to twitchdev/issues - opened twitchdev/issues/issues/375 there.

I'll reopen this for the time being, will re-close if Twitch decides to ignore me (as it does usually).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Something out of our power needs to change before proceeding with this issue bug Something isn't working as intended, or works in a confusing/unintuitive way for the user Platform: Twitch
Projects
None yet
Development

No branches or pull requests

5 participants