Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tuling123-bot.ts #1014

Merged
merged 1 commit into from
Jan 18, 2018
Merged

Update tuling123-bot.ts #1014

merged 1 commit into from
Jan 18, 2018

Conversation

htoooth
Copy link
Contributor

@htoooth htoooth commented Dec 15, 2017

fix tuling123-bot error

fix tuling123-bot error
@huan
Copy link
Member

huan commented Dec 15, 2017

Thanks for the PR.

Does this mean the tuling API client changed its behaviour?

@htoooth
Copy link
Contributor Author

htoooth commented Dec 19, 2017

I found that tuling123'api is not changed. This example always run error.

I check this module. Tuling123'api ask always return Promise. And Now, the tuling bot's result is {code: number, text: string}. you should have a try.

Test case is not pass. I don't know why. I'm not change other file. This testcase is not pass in
test/fixture/docker/type-error.ts file:

let i = 3
i = "should set to string because it's type is number"
console.log(i)

@zixia

@huan
Copy link
Member

huan commented Jan 18, 2018

@htoooth Sorry for the late reply.

I'll merge this and have a try.

Thank you very much for the contribution!

@huan huan merged commit f3a416d into wechaty:master Jan 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants