-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Standard" properties; case-insensitive handling of property names #48
Comments
So, I have opened a PR with the above fix. Also, I have added support to allow users to search for channels where the property and tag names are case insensitive.
Note: |
Very good progress! For channel and property names, yes, EPICS channel names are certainly case-sensitive. The channel finder absolutely needs to preserve the case, otherwise a "caget" will fail. |
Ah!!!
I think I very much agree with this...I think we go ahead and make channel name and property value searches also case insensitive... but we preserve case in the name and property value so that usage in things like caget and other links to from the property value which are case sensitive continue to work |
Great work Kunal!! And +1 on Kay's comment, I am in that 99.89% group too |
Done Adding some simple integration tests I don't believe this should have any major impact on any app/users |
The "standard" property names used by channel finder itself as well as the 'rec sync' package which is the de-facto standard for populating channel finder data uses a mix of upper/lower case:
Name
,Owner
start with capital letteriocid
,time
and the suggestedarchive
marker are all lower casehostName
,iocName
,pvStatus
,recordType
are wonky camelCaseThe example recsync IOCs set environment variables
LOCATION
andENGINEER
, somewhat suggesting that they matter and end up in channel finder properties, which at this time they don't, but if they eventually will, would that be asLOCATION
,Location
,location
, ...?The "Channel Table" would look better with consistent casing, for example strict CamelCase:
Name, Owner, Hostname, IocName, IocId, PvStatus, RecordType, Time, Location, Engineer, ...
Simply changing the properties now would of course break existing installations because the search is case-sensitive. But then the case-sensitive nature of property names is actually another issue because users need to remember that searching by record type requires typing "recordType".
So at the same time of adjusting the PropertyNameCase we could make the search case-insensitive regarding property names, so any of "recordtype=ai", "recordType=ai", "RecordType=ai", "RECORDTYPE=ai" would give the same result.
The text was updated successfully, but these errors were encountered: