Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More gc time on main thread since Mar 26 #6606

Closed
twoeths opened this issue Mar 28, 2024 · 2 comments · Fixed by #6607
Closed

More gc time on main thread since Mar 26 #6606

twoeths opened this issue Mar 28, 2024 · 2 comments · Fixed by #6607
Labels
meta-bug Issues that identify a bug and require a fix.

Comments

@twoeths
Copy link
Contributor

twoeths commented Mar 28, 2024

Describe the bug

gc time has increased since Mar 26 on main thread, this happens on unstable group

Screenshot 2024-03-28 at 14 00 23

when I review related PR, it's possible increasing seen_ttl caused it https://github.com/ChainSafe/lodestar/pull/6569/files

however that change should only affect the network thread, and actually network thread gc time decreased since Mar 26

Screenshot 2024-03-28 at 14 04 29

Expected behavior

gc should be the same, or find out the reason

Steps to reproduce

No response

Additional context

No response

Operating system

Linux

Lodestar version or commit hash

unstable

@twoeths twoeths added the meta-bug Issues that identify a bug and require a fix. label Mar 28, 2024
@twoeths
Copy link
Contributor Author

twoeths commented Mar 28, 2024

Cache size decreased significantly

Screenshot 2024-03-28 at 14 24 18

that forced main thread to receive more messages

Screenshot 2024-03-28 at 14 25 56

that was due to we changed the seen_ttl in second instead of ms

@twoeths
Copy link
Contributor Author

twoeths commented Apr 2, 2024

cache size is increased as expected on unstable mainnet node

Screenshot 2024-04-02 at 10 52 06

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta-bug Issues that identify a bug and require a fix.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant