Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Info UX improvements #4133

Closed
philknows opened this issue Jun 8, 2022 · 2 comments · Fixed by #4350
Closed

Merge Info UX improvements #4133

philknows opened this issue Jun 8, 2022 · 2 comments · Fixed by #4350
Assignees
Labels
prio-medium Resolve this some time soon (tm). scope-ux Issues for CLI UX or general consumer UX.

Comments

@philknows
Copy link
Member

philknows commented Jun 8, 2022

UPDATE: Enlarging the scope of the issue to:

  • Optimize the merge tracker
  • Add merge metrics
  • Add merge info logger
    Is your feature request related to a problem? Please describe.

Reference Lighthouse issue: sigp/lighthouse#3249

This was mentioned in the Eth R&D chats as a beneficial UX opportunity for those running Lodestar awaiting the transition up to the merge.

Currently Teku has this in their logs:
teku | 10:29:18.306 INFO - TTD ETA: 0 days, 4 hours and 22 minutes (8 Jun 2022 - 14:51:48) - Current Total Difficulty: 0x00000000000000000000000000000000000000000000000000ace84463a84fd1

Describe the solution you'd like

It would be good for Lodestar to periodically log a line that shows:

  • Difficulty of last block in a non-hex format
  • Total difficulty required to hit merge (re-iterates that the TTD settings are correct)
  • ETA if we are able to get the hashrate or total avg difficulty of previous X blocks (whatever metric would be best to estimate)
@philknows philknows added the scope-ux Issues for CLI UX or general consumer UX. label Jun 8, 2022
@dapplion
Copy link
Contributor

dapplion commented Jun 9, 2022

Sounds good! I support this

@dapplion dapplion added the prio-medium Resolve this some time soon (tm). label Jul 13, 2022
@dapplion
Copy link
Contributor

Implementation guidelines for implementer

Create a new TimeSeries with more points (100) to track TTD

const timeSeries = new TimeSeries({maxPoints: 10});

ttd should be exposed on a getter on this class

export class Eth1MergeBlockTracker {

everytime it fetches a block, persist the max TD seen in a variable this.maxTD. Then this variable should be re-used in a counter collect fn

@g11tech g11tech moved this from Todo to In Progress in Lodestar Sprint Planning Jul 25, 2022
@g11tech g11tech changed the title Logging TTD periodically with details leading up to a merge. Merge Info UX improvements Jul 29, 2022
Repository owner moved this from In Progress to Done in Lodestar Sprint Planning Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
prio-medium Resolve this some time soon (tm). scope-ux Issues for CLI UX or general consumer UX.
Projects
No open projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants