Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gossip should support 10MB messages in Bellatrix #3776

Closed
jtraglia opened this issue Feb 19, 2022 · 3 comments
Closed

Gossip should support 10MB messages in Bellatrix #3776

jtraglia opened this issue Feb 19, 2022 · 3 comments
Assignees
Labels
spec-bellatrix 🐼 Issues targeting the merge spec version.

Comments

@jtraglia
Copy link

Currently, Lodestar has a 1MB max message size (in master & kintsugi branches):

/** The maximum allowed size of uncompressed gossip messages. */
export const GOSSIP_MAX_SIZE = 2 ** 20;
/** The maximum allowed size of uncompressed req/resp chunked responses. */
export const MAX_CHUNK_SIZE = 2 ** 20;

For Bellatrix, the spec states that the maximum gossip message size is 10MB:

https://github.com/ethereum/consensus-specs/blob/dev/specs/bellatrix/p2p-interface.md#configuration

I suggest creating new GOSSIP_MAX_SIZE_BELLATRIX and MAX_CHUNK_SIZE_BELLATRIX constants.

@dapplion
Copy link
Contributor

Thanks for noting this @jtraglia ❤️

@g11tech
Copy link
Contributor

g11tech commented Feb 22, 2022

thanks @jtraglia for bringing this up! 🙂 we have this tracked here: #3486. Current plan is to raise the limit in a release just before merge 👍

@philknows philknows added the spec-bellatrix 🐼 Issues targeting the merge spec version. label Feb 25, 2022
@jtraglia
Copy link
Author

Tracked elsewhere. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec-bellatrix 🐼 Issues targeting the merge spec version.
Projects
None yet
Development

No branches or pull requests

4 participants