-
-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add good full coverage beacon API tests #3682
Comments
More disabled tests
lodestar/packages/lodestar/test/unit/api/impl/debug/index.test.ts Lines 20 to 21 in 5d086b5
lodestar/packages/lodestar/test/unit/chain/factory/block/blockAssembly.test.ts Lines 21 to 22 in 5d086b5
|
We now have oapi schema compliance tests that ensure validity of request/response data shapes and proper support of headers, status codes, etc. This is a good halfway solution. |
What is your question?
Current tests for the beacon API are of sub-optimal quality:
In my subjective opinion the current test suite has a very high cost of maintenance with very little return in ensuring the API is correct.
Proposed solution
Proper tests for a the beacon API should:
The text was updated successfully, but these errors were encountered: