New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle keepalive failure #92

Open

wemeetagain opened this issue Oct 9, 2024 · 0 comments

Labels

Member

wemeetagain commented Oct 9, 2024 •

edited

Loading

KeepAlive is not mentioned in the Yamux spec but looking a the implementation if the keepalive ping fails the connection should be closed.

It looks like we just ignore any keepalive faliures here which is probably incorrect.

Originally posted by @achingbrain in #76 (comment)

wemeetagain added the prio-low label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment