Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate record of msgReceivedPreValidation metric #228

Merged
merged 1 commit into from
Apr 7, 2022
Merged

Remove duplicate record of msgReceivedPreValidation metric #228

merged 1 commit into from
Apr 7, 2022

Conversation

twoeths
Copy link
Contributor

@twoeths twoeths commented Apr 7, 2022

Description
this.metrics?.onMsgRecvPreValidation(rpcMsg.topic) was called in both handleReceivedMessage and validateReceivedMessage

@twoeths twoeths requested a review from a team April 7, 2022 06:07
@dapplion dapplion merged commit 68d1b0c into master Apr 7, 2022
@dapplion dapplion deleted the tuyen/duplicate-onMsgRecvPreValidation branch April 7, 2022 14:58
@mpetrunic mpetrunic mentioned this pull request May 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dapplion dapplion dapplion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@twoeths @dapplion