Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unbundle 2-label metrics #433

Merged
merged 2 commits into from
Jun 14, 2023
Merged

Conversation

twoeths
Copy link
Contributor

@twoeths twoeths commented Jun 12, 2023

Motivation

  • On network thread, it takes 3% of cpu time for gauge.inc()
Screenshot 2023-06-12 at 14 22 12

Description

  • Use single-label metric to improve performance

Closes #426

@codecov-commenter
Copy link

codecov-commenter commented Jun 12, 2023

Codecov Report

Patch coverage: 3.33% and project coverage change: -0.22 ⚠️

Comparison is base (324c693) 82.96% compared to head (eb89073) 82.74%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #433      +/-   ##
==========================================
- Coverage   82.96%   82.74%   -0.22%     
==========================================
  Files          48       48              
  Lines       11896    11930      +34     
  Branches     1282     1282              
==========================================
+ Hits         9869     9871       +2     
- Misses       2027     2059      +32     
Impacted Files Coverage Δ
src/metrics.ts 19.67% <3.33%> (-0.61%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@twoeths twoeths marked this pull request as ready for review June 13, 2023 01:46
@twoeths twoeths requested a review from a team as a code owner June 13, 2023 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unbundle metrics with 2 labels
3 participants