Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle closing outbound stream #314

Merged
merged 1 commit into from
Aug 8, 2022

Conversation

twoeths
Copy link
Contributor

@twoeths twoeths commented Aug 8, 2022

Motivation

  • The pushable inside Outbound stream keeps some internal buffers inside, we need to clear them when closing the OutboundStream or it becomes a memory leak if the raw stream is also closed

Screen Shot 2022-08-08 at 10 22 55

Description

  • End the pushable by calling return() method when closing outbound stram - it's similar to end() but also clearing the internal buffers inside the pushable
  • Track the inbound/outbound streams in the metrics

@twoeths twoeths requested a review from a team as a code owner August 8, 2022 03:25
@wemeetagain wemeetagain merged commit 74c08b1 into master Aug 8, 2022
@wemeetagain wemeetagain deleted the tuyen/close-OutboundStream branch August 8, 2022 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants