Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ovararching problem with our previous approach is that we're too carefree about managing streams for this protocol.
Specific problems include:
Creation and tracking of new streams is tweaked:
This used to ensure that outbound streams are created sequentially.
This stops multiple duplicate streams from being created for a single peer.
This allows us to connect to peers that haven't yet been registered by the topology but want to connect to us.
PeerStreams
usage in favor of managing inbound/outbound streams separatelyPeerStreams
works, but obscures some lingering issues. It's also quite inflexible and annoying to modify it sincePeerStreams
implements an interface in@libp2p/interface-pubsub
.