Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rpc): implement Filecoin.NetProtectList #4783

Merged
merged 4 commits into from
Sep 24, 2024
Merged

feat(rpc): implement Filecoin.NetProtectList #4783

merged 4 commits into from
Sep 24, 2024

Conversation

hanabi1224
Copy link
Contributor

@hanabi1224 hanabi1224 commented Sep 23, 2024 •
edited
Loading

Summary of changes

Changes introduced in this pull request:

  • implement Filecoin.NetProtectList
  • API compare tests

Reference issue to close (if applicable)

Closes #4752

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@hanabi1224 hanabi1224 marked this pull request as ready for review September 23, 2024 10:07
@hanabi1224 hanabi1224 requested a review from a team as a code owner September 23, 2024 10:07
@hanabi1224 hanabi1224 requested review from lemmih and LesnyRumcajs and removed request for a team September 23, 2024 10:07
LesnyRumcajs
LesnyRumcajs approved these changes Sep 23, 2024
View reviewed changes
Copy link
Member

@LesnyRumcajs LesnyRumcajs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog entry?

@hanabi1224
Copy link
Contributor Author

Changelog entry?

@LesnyRumcajs Added

@lemmih lemmih added this pull request to the merge queue Sep 24, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 24, 2024
@hanabi1224 hanabi1224 added this pull request to the merge queue Sep 24, 2024
Merged via the queue into main with commit 0c31c02 Sep 24, 2024
32 checks passed
@hanabi1224 hanabi1224 deleted the hm/NetProtectList branch September 24, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lemmih lemmih lemmih approved these changes

@LesnyRumcajs LesnyRumcajs LesnyRumcajs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Filecoin.NetProtectList
3 participants
@hanabi1224 @lemmih @LesnyRumcajs