Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all methods to v1 #4678

Closed
aatifsyed opened this issue Aug 22, 2024 · 1 comment · Fixed by #4768
Closed

Move all methods to v1 #4678

aatifsyed opened this issue Aug 22, 2024 · 1 comment · Fixed by #4768
Assignees

Comments

@aatifsyed
Copy link
Contributor

aatifsyed commented Aug 22, 2024

As a prerequisite to #3960, following the failure of #4516, I think we should, for all methods:

  • bump API_VERSION: ApiVersion = ApiVersion::V1 if possible.

This should be done in parts, as our tests will break when we come across incompatible methods.

Adding support back in for V0 should be a future task.

This is necessary for producing an up-to-date Common Node API spec - we must be confident that all methods are V1, so we should prioritize Common Node API methods

@hanabi1224
Copy link
Contributor

FYI, as of CI in #4448 run, all RPC methods were V1 compatible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants