Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect version is returned in the Version RPC method #4498

Closed
elmattic opened this issue Jul 10, 2024 · 0 comments · Fixed by #4683
Closed

Incorrect version is returned in the Version RPC method #4498

elmattic opened this issue Jul 10, 2024 · 0 comments · Fixed by #4683
Assignees
@LesnyRumcajs
Labels
Priority: 2 - High Very important and should be addressed ASAP Type: Bug Something isn't working

Comments

@elmattic
Copy link
Contributor

elmattic commented Jul 10, 2024 •
edited by ansermino
Loading

Issue summary

According to magik6k, we shouldn't return the Forest version for our Version endpoint but rather:

  • 1.5.0 for v0 API
  • 2.3.0 for v1 API

These correspond to the version of Filecoin (?) spec

Other information and links

https://github.com/ChainSafe/forest/blob/main/src/rpc/methods/common.rs#L32-L50
@lemmih lemmih added Type: Bug Something isn't working Priority: 2 - High Very important and should be addressed ASAP labels Aug 2, 2024
@ansermino ansermino mentioned this issue Aug 21, 2024
Open
7 tasks
@LesnyRumcajs LesnyRumcajs self-assigned this Aug 26, 2024
@LesnyRumcajs LesnyRumcajs mentioned this issue Aug 26, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LesnyRumcajs LesnyRumcajs

Labels
Priority: 2 - High Very important and should be addressed ASAP Type: Bug Something isn't working
Projects
Forest Backlog 🌲
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: APIVersion in Filecoin.Version ChainSafe/forest
3 participants
@lemmih @LesnyRumcajs @elmattic