Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Rename and document get_circulating_supply. #4153

Closed
ruseinov opened this issue Apr 8, 2024 · 0 comments · Fixed by #4157
Closed

[Enhancement] Rename and document get_circulating_supply. #4153

ruseinov opened this issue Apr 8, 2024 · 0 comments · Fixed by #4157

Comments

@ruseinov
Copy link
Contributor

ruseinov commented Apr 8, 2024 

          Rename `get_circulating_supply` to `get_state_circulating_supply`.

Document the difference between get_vm_circulating_supply and get_state_circulating_supply.
Possibly move get_state_circulating_supply out of vm_circ_supply.rs as it's confusing.

Originally posted by @ruseinov in #4084 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Enhcancement] get_state_circulating_supply. ChainSafe/forest
1 participant
@ruseinov