Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Ethereum method aliases #3959

Closed
3 tasks done
elmattic opened this issue Feb 16, 2024 · 0 comments · Fixed by #4606
Closed
3 tasks done

Implement Ethereum method aliases #3959

elmattic opened this issue Feb 16, 2024 · 0 comments · Fixed by #4606
Assignees
@LesnyRumcajs

Comments

@elmattic
Copy link
Contributor

elmattic commented Feb 16, 2024 •
edited by LesnyRumcajs
Loading

Issue summary

Lotus supports method aliases for its Ethereum JSON-RPC API.

See file https://github.com/filecoin-project/lotus/blob/v1.25.2/api/eth_aliases.go.

We should implement similar support.

Task summary

  • Implement similar aliasing
  • Find a way to test that aliases work too (this could be done in forest-tool api compare)

Acceptance Criteria

  • Tests are passing

Other information and links

https://docs.rs/jsonrpsee/0.22.0/jsonrpsee/struct.RpcModule.html#method.register_alias
(dependent on #3943)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LesnyRumcajs LesnyRumcajs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add Eth method aliasing ChainSafe/forest
2 participants
@LesnyRumcajs @elmattic