Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update buffered blockstore to only write values connected to root #377

Closed
austinabell opened this issue Apr 24, 2020 · 0 comments
Closed
Assignees
Labels
Priority: 4 - Low Limited impact and can be implemented at any time

Comments

@austinabell
Copy link
Contributor

Issue summary

BufferedBlockstore currently acts to cache all changes and write once the transition is confirmed valid (although can be used in many cases to avoid unnecessary writes)

I created the TODO in changes from #374 here:

// TODO update this to only write over values connected to the root
and explained at a high level what needs to be done.

Implementation is not set in stone, and I did chose to create the interface as flushing the store, but implementation could match go impls more closely by copying values from one blockstore (usally an in memory store) to another. I chose to go with this route to not need mutexes for the memory store (This is only used in sync context) and because it made more logical sense to be a flush.

This issue is borderline good first issue, but because of the complexity of parsing the IPLD for links and recursively retrieving, I won't mark as such

Other information and links

@austinabell austinabell added Priority: 4 - Low Limited impact and can be implemented at any time Blockchain labels Apr 24, 2020
@austinabell austinabell self-assigned this Apr 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: 4 - Low Limited impact and can be implemented at any time
Projects
None yet
Development

No branches or pull requests

1 participant