-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to a custom allocator by default #2607
Comments
Here's the snapshot import benchmark result I got on DO droplet
Block validation metrics on mainnet
|
So let's ship |
Sounds good to me. |
Yeah, sounds reasonable. |
@hanabi1224 what about validation time? |
@elmattic I did not run validation but I think the bottleneck of validation is not database but fvm |
Agree, but memory allocator should have an impact on the fvm, so validation time too, no? |
@elmattic OK, I can collect |
I will run the ruby benchmark script on my side on a Fedora 37. |
@elmattic Sounds good, thx! At the same time, I will run forest with different allocators and fetch metrics with the below command
|
@elmattic block validation metrics updated, no obvious gain or loss is observed. |
Issue summary
Once we have the benchmark results comparing
mimalloc
,jemalloc
and the default allocator, we should decide which one to use by default. Most likely, based on the feedback from @elmattic and @hanabi1224 it would be one of the custom ones.Other information and links
The text was updated successfully, but these errors were encountered: