Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration file doesn't work for many flags #2573

Closed
LesnyRumcajs opened this issue Feb 21, 2023 · 0 comments · Fixed by #2577
Closed

Configuration file doesn't work for many flags #2573

LesnyRumcajs opened this issue Feb 21, 2023 · 0 comments · Fixed by #2577
Assignees
Labels
Type: Bug Something isn't working

Comments

@LesnyRumcajs
Copy link
Member

Describe the bug

Providing a configuration file, either via --config or through other means, doesn't work with a bunch of flags that get overridden in to_config after parsing the aforementioned file.

To Reproduce
Steps to reproduce the behavior:

  1. Create a config file with one of the faulty entries, e.g.,
[client]
halt_after_import = true
  1. Run forest --config <FILE>
  2. See that the flag gets ignored (Forest will continue to sync)
  3. See that forest --config <FILE> --halt-after-import works fine.

Expected behaviour

Configuration file parameters are not overridden by CliOpts defaults.

Screenshots

Environment (please complete the following information):

  • OS: Fedora Linux 37
  • Rust version(e.g. rustc --version)
  • Branch/commit 5903083

Other information and links

@LesnyRumcajs LesnyRumcajs added the Type: Bug Something isn't working label Feb 21, 2023
@LesnyRumcajs LesnyRumcajs self-assigned this Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working
Projects
No open projects
Status: No status
Development

Successfully merging a pull request may close this issue.

1 participant