Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIP 29 - Beneficiary address for storage providers #1902

Closed
4 tasks done
lemmih opened this issue Sep 13, 2022 · 1 comment
Closed
4 tasks done

FIP 29 - Beneficiary address for storage providers #1902

lemmih opened this issue Sep 13, 2022 · 1 comment

Comments

@lemmih
Copy link
Contributor

lemmih commented Sep 13, 2022

Issue summary

Checklist:

  • Are there any changes to the actor data structures that we need to be aware of?
  • Are there any changes to the network protocol?
  • Are there any changes to node behavior (eg. changes in block validation criteria, random number generation, etc)?
  • Are there any new magic numbers?

Other information and links

FIP: https://github.com/filecoin-project/FIPs/blob/master/FIPS/fip-0029.md

@lemmih lemmih added Status: Needs Triage Issue has unresolved discussions and/or needs to be assigned a priority and assignee Ready Issue is ready for work and anyone can freely assign it to themselves and removed Status: Needs Triage Issue has unresolved discussions and/or needs to be assigned a priority and assignee Ready Issue is ready for work and anyone can freely assign it to themselves labels Sep 13, 2022
@lemmih lemmih added this to the Forest 🌲 in Beta milestone Sep 13, 2022
@LesnyRumcajs LesnyRumcajs self-assigned this Sep 19, 2022
@LesnyRumcajs
Copy link
Member

LesnyRumcajs commented Sep 21, 2022

Beneficiary information in state

There will be a change to MinerInfo struct. We have it copied from builtin-actors. Perhaps it will be an opportunity to import it and reduce duplication. Otherwise, we can just copy the updated version.

Withdrawals to beneficiary

Internal in builtin-actors.

Setting the beneficiary address

Internal in builtin-actors.

Related PR: filecoin-project/builtin-actors#496

There shouldn't be any consensus change. We should be good with updating the builtin-actors dependency and importing or copying the MinerInfo struct to Forest.

⚠️ Tests ⚠️
Those structs are used only in our RPC API which is not covered by tests. It would be great to at least test that it works manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: No status
Development

No branches or pull requests

2 participants