Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup net peers output #1184

Closed
2 tasks
cryptoquick opened this issue Jul 5, 2021 · 0 comments · Fixed by #1199
Closed
2 tasks

Cleanup net peers output #1184

cryptoquick opened this issue Jul 5, 2021 · 0 comments · Fixed by #1199
Labels
good first issue Priority: 4 - Low Limited impact and can be implemented at any time

Comments

@cryptoquick
Copy link
Contributor

cryptoquick commented Jul 5, 2021

Task summary
net peers prints a lot of extraneous information that's either redundant or not useful.

Acceptance criteria

  • net peers has no duplicate Multiaddrs
  • net peers does not show localhost or loopback ip4 and ip6 routes

Other information and links
Compare the output of lotus net peers:
Screenshot from 2021-07-05 09-18-33

...with the output of forest net peers:
Screenshot from 2021-07-05 09-18-04

A lotta extra junk!

  • Be sure to note: It's okay to have multiple routes, for example, we might have an external ip4 route and an external ip6 route to a peer, so this task isn't as simple as selecting a single route per peer, we still need to return the vector, even though the majority are a single external ip4 route.
@cryptoquick cryptoquick added the Status: Needs Triage Issue has unresolved discussions and/or needs to be assigned a priority and assignee label Jul 5, 2021
@ec2 ec2 added good first issue Priority: 4 - Low Limited impact and can be implemented at any time and removed Status: Needs Triage Issue has unresolved discussions and/or needs to be assigned a priority and assignee labels Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Priority: 4 - Low Limited impact and can be implemented at any time
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants