Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Forest CLI] Fix panic when passing a malformed address to wallet set-default #1166

Closed
cryptoquick opened this issue Jun 14, 2021 · 0 comments
Closed

[Forest CLI] Fix panic when passing a malformed address to wallet set-default #1166

cryptoquick opened this issue Jun 14, 2021 · 0 comments
Assignees
@connormullett

Comments

@cryptoquick
Copy link
Contributor

Task summary

forest wallet set-default works fine when providing a proper address, but if a malformed address is given (say, but adding junk to the end), forest quits with a panic.

Specification reference

  • forest wallet set-default <address>$ome3xtraJunk no longer panics, but ideally returns a 400 (Bad Request).

Other information and links

#1128 (review)
@cryptoquick cryptoquick added the Status: Needs Triage Issue has unresolved discussions and/or needs to be assigned a priority and assignee label Jun 14, 2021
@cryptoquick cryptoquick mentioned this issue Jun 14, 2021
Merged
@connormullett connormullett self-assigned this Jun 16, 2021
@connormullett connormullett mentioned this issue Jun 16, 2021
Merged
@lerajk lerajk closed this as completed Jul 20, 2021
@ec2 ec2 removed the Status: Needs Triage Issue has unresolved discussions and/or needs to be assigned a priority and assignee label Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@connormullett connormullett

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@cryptoquick @ec2 @lerajk @connormullett