Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New transaction list design #258

Open
Tbaut opened this issue Jul 17, 2023 · 0 comments
Open

New transaction list design #258

Tbaut opened this issue Jul 17, 2023 · 0 comments
Labels
Priority: 🟡 P2 Added to issues and PRs relating to a medium severity bugs. Type: 🫶 Enhancement Added to issues and PRs when a change includes improvements or optimizations.

Comments

@Tbaut
Copy link
Collaborator

Tbaut commented Jul 17, 2023

We want to get close to this:
image
Figma: https://www.figma.com/file/4dQC9kxf5uxCrAjpkzAK0D/Multix?node-id=839%3A27810&mode=dev

Note that this issue has some differences compared to the design and some more info is needed to actually cater for the real world use case.

  • We show the account that is submitting the Tx, either a multi or a pure. This is new and not currently implemented.
  • The Badge should be like on other view directly following the account (using the AccountDisplay component without needing changes IMHO), unlike on the screenshot/Figma
  • no need to put numbers, the ordering is done per date already
  • Expanding the view should show the params of the transaction (similar as now).
  • We do not need the 3 dots buttons for now
  • I don't know how to display who signed and who yet needs to sign. Open to any suggestion.
  • the button should be named "review" unlike on the design. It shouldn't be displayed if all the available signers have signed already and if you're not the proposer (the logic is already implemented right now)
@Tbaut Tbaut added Priority: 🟠 P1 Added to issues and PRs relating to a high severity bugs. Type: 🫶 Enhancement Added to issues and PRs when a change includes improvements or optimizations. Priority: 🟡 P2 Added to issues and PRs relating to a medium severity bugs. and removed Priority: 🟠 P1 Added to issues and PRs relating to a high severity bugs. labels Jul 17, 2023
@Lykhoyda Lykhoyda self-assigned this Sep 19, 2023
@Lykhoyda Lykhoyda removed their assignment Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: 🟡 P2 Added to issues and PRs relating to a medium severity bugs. Type: 🫶 Enhancement Added to issues and PRs when a change includes improvements or optimizations.
Projects
None yet
Development

No branches or pull requests

2 participants