Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Making jenkins run the distro jobs in parallel #660

Merged
merged 3 commits into from
Aug 28, 2018
Merged

Making jenkins run the distro jobs in parallel #660

merged 3 commits into from
Aug 28, 2018

Conversation

p3ck
Copy link
Contributor

@p3ck p3ck commented Aug 27, 2018

No description provided.

@adl-bot
Copy link

adl-bot commented Aug 27, 2018

ci-linchpin-messageBus-trigger build #185: FAILURE: https://jenkins-continuous-infra.cloud.continuous-infra.upshift.redhat.com/job/ci-linchpin-messageBus-trigger/185/

@p3ck p3ck force-pushed the parallel_jenkins branch 2 times, most recently from a96bfdc to 9130cfc Compare August 27, 2018 19:40
@p3ck p3ck changed the title WIP - making jenkins run the distro jobs in parallel Making jenkins run the distro jobs in parallel Aug 27, 2018
@adl-bot
Copy link

adl-bot commented Aug 27, 2018

ci-linchpin-messageBus-trigger build #187: FAILURE: https://jenkins-continuous-infra.cloud.continuous-infra.upshift.redhat.com/job/ci-linchpin-messageBus-trigger/187/

@adl-bot
Copy link

adl-bot commented Aug 27, 2018

ci-linchpin-messageBus-trigger build #188: FAILURE: https://jenkins-continuous-infra.cloud.continuous-infra.upshift.redhat.com/job/ci-linchpin-messageBus-trigger/188/

johnbieren
johnbieren reviewed Aug 27, 2018
View reviewed changes
config/Dockerfiles/Jenkinsfile Outdated
remote: "https://github.com/CentOS-Paas-SIG/ci-pipeline"])
def libraries = ['cico-pipeline' : ['master', 'https://github.com/CentOS/cico-pipeline-library.git'],
'ci-pipeline' : ['master', 'https://github.com/CentOS-PaaS-SIG/ci-pipeline.git'],
'upstream-fedora-pipeline': ['smalltest', 'https://github.com/johnbieren/upstream-fedora-pipeline.git']]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you +1 this:
CentOS-PaaS-SIG/ci-pipeline#716
You can remove this shared library and change the following lines from
packagepipelineUtils.clearTemplateNames()
to
pipelineUtils.clearTemplateNames()
Lines 100, 133, 166

@p3ck p3ck force-pushed the parallel_jenkins branch from 9130cfc to 0c897cc Compare August 27, 2018 23:23
@adl-bot
Copy link

adl-bot commented Aug 27, 2018

ci-linchpin-messageBus-trigger build #192: FAILURE: https://jenkins-continuous-infra.cloud.continuous-infra.upshift.redhat.com/job/ci-linchpin-messageBus-trigger/192/

@p3ck p3ck force-pushed the parallel_jenkins branch from 0c897cc to 927ab84 Compare August 28, 2018 13:35
@adl-bot
Copy link

adl-bot commented Aug 28, 2018

ci-linchpin-messageBus-trigger build #194: SUCCESS: https://jenkins-continuous-infra.cloud.continuous-infra.upshift.redhat.com/job/ci-linchpin-messageBus-trigger/194/

@p3ck p3ck requested review from herlo and samvarankashyap August 28, 2018 13:45
johnbieren
johnbieren approved these changes Aug 28, 2018
View reviewed changes
Copy link
Contributor

@johnbieren johnbieren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@p3ck p3ck force-pushed the parallel_jenkins branch 2 times, most recently from b1d529b to fcae1b0 Compare August 28, 2018 14:01
@adl-bot
Copy link

adl-bot commented Aug 28, 2018

ci-linchpin-messageBus-trigger build #195: SUCCESS: https://jenkins-continuous-infra.cloud.continuous-infra.upshift.redhat.com/job/ci-linchpin-messageBus-trigger/195/

@adl-bot
Copy link

adl-bot commented Aug 28, 2018

ci-linchpin-messageBus-trigger build #196: FAILURE: https://jenkins-continuous-infra.cloud.continuous-infra.upshift.redhat.com/job/ci-linchpin-messageBus-trigger/196/

@adl-bot
Copy link

adl-bot commented Aug 28, 2018

ci-linchpin-messageBus-trigger build #199: FAILURE: https://jenkins-continuous-infra.cloud.continuous-infra.upshift.redhat.com/job/ci-linchpin-messageBus-trigger/199/

@p3ck p3ck force-pushed the parallel_jenkins branch from fcae1b0 to 141ce36 Compare August 28, 2018 14:31
@p3ck
Copy link
Contributor Author

p3ck commented Aug 28, 2018

[test] - failed on duffy

@adl-bot
Copy link

adl-bot commented Aug 28, 2018

ci-linchpin-messageBus-trigger build #201: SUCCESS: https://jenkins-continuous-infra.cloud.continuous-infra.upshift.redhat.com/job/ci-linchpin-messageBus-trigger/201/

@p3ck
Use openshift locking to keep openshift instance from going away.
d7b5166 
Without this if you run multiple openshift.withCluster() in parallel you
may lose your instance when one of them finishes..

Long term, we should move the openshift.* methods to outside our
parallel methods.
@adl-bot
Copy link

adl-bot commented Aug 28, 2018

ci-linchpin-messageBus-trigger build #202: FAILURE: https://jenkins-continuous-infra.cloud.continuous-infra.upshift.redhat.com/job/ci-linchpin-messageBus-trigger/202/

@adl-bot
Copy link

adl-bot commented Aug 28, 2018

ci-linchpin-messageBus-trigger build #203: FAILURE: https://jenkins-continuous-infra.cloud.continuous-infra.upshift.redhat.com/job/ci-linchpin-messageBus-trigger/203/

@p3ck
Still getting the getServerUrl on null object every so often.
3fab278 
Removing the lock, added openshift.withCluster() and
openshift.withProject().  Might still need to modify the helper
functions to not call those methods any more.
@adl-bot
Copy link

adl-bot commented Aug 28, 2018

ci-linchpin-messageBus-trigger build #204: SUCCESS: https://jenkins-continuous-infra.cloud.continuous-infra.upshift.redhat.com/job/ci-linchpin-messageBus-trigger/204/

@p3ck
Copy link
Contributor Author

p3ck commented Aug 28, 2018

[test] libvirtd failed to start

@adl-bot
Copy link

adl-bot commented Aug 28, 2018

ci-linchpin-messageBus-trigger build #205: SUCCESS: https://jenkins-continuous-infra.cloud.continuous-infra.upshift.redhat.com/job/ci-linchpin-messageBus-trigger/205/

@p3ck
Copy link
Contributor Author

p3ck commented Aug 28, 2018

[merge]

@adl-bot adl-bot merged commit 8b2baa5 into CentOS-PaaS-SIG:develop Aug 28, 2018
@adl-bot adl-bot mentioned this pull request Dec 10, 2018
Merged
@adl-bot adl-bot mentioned this pull request Nov 19, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnbieren johnbieren johnbieren approved these changes

@herlo herlo Awaiting requested review from herlo

@samvarankashyap samvarankashyap Awaiting requested review from samvarankashyap

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@p3ck @adl-bot @johnbieren