Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CatBlock is not replacing ads with cats #77

Closed
tomasko126 opened this issue Sep 9, 2016 · 0 comments · Fixed by #78
Closed

CatBlock is not replacing ads with cats #77

tomasko126 opened this issue Sep 9, 2016 · 0 comments · Fixed by #78
Assignees
@tomasko126
Labels
bug This is a bug with the extension pr-high This is a high-priority issue. If you want to help out, try one of these if you can!
Milestone
1.4.1-1.4.x

Comments

@tomasko126
Copy link
Member

A regression of #66 has been identified, leading to not displaying replaced images of cats.
@tomasko126 tomasko126 added bug This is a bug with the extension pr-high This is a high-priority issue. If you want to help out, try one of these if you can! labels Sep 9, 2016
@tomasko126 tomasko126 added this to the 1.4.1-1.4.x milestone Sep 9, 2016
@tomasko126 tomasko126 self-assigned this Sep 9, 2016
@tomasko126 tomasko126 mentioned this issue Sep 9, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tomasko126 tomasko126

Labels
bug This is a bug with the extension pr-high This is a high-priority issue. If you want to help out, try one of these if you can!
Projects
None yet
Milestone
1.4.1-1.4.x
Development

Successfully merging a pull request may close this issue.

Simplify an algorithm for getting width and height CatBlock/catblock
1 participant
@tomasko126