Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address Firefox review #130

Closed
itskdog opened this issue Jan 28, 2017 · 1 comment · Fixed by #131 or #132
Closed

Address Firefox review #130

itskdog opened this issue Jan 28, 2017 · 1 comment · Fixed by #131 or #132
Assignees
@tomasko126
Labels
br-firefox This only affects Firefox bug This is a bug with the extension pr-high This is a high-priority issue. If you want to help out, try one of these if you can!
Milestone
1.5.1

Comments

@itskdog
Copy link
Member

itskdog commented Jan 28, 2017

  1. We generally don't accept using the 'eval' function. There are many reasons not to use 'eval', and there are alternatives available. You can read more about it here: https://developer.mozilla.org/en/XUL_School/Appendix_C:_Avoid_using_eval_in_Add-ons
  • catblock/channels.js line 38, 41

  1. Please use non-custom versions of jquery-ui, as well as the stock version of jquery, that match the checksums in https://github.com/mozilla/amo-validator/blob/master/validator/testcases/hashes-allowed.txt

  2. Your CSP allows various unsafe operations including remote script execution. Please remove the unsafe-* values and find alternatives for your source code.
@itskdog itskdog added br-firefox This only affects Firefox bug This is a bug with the extension pr-high This is a high-priority issue. If you want to help out, try one of these if you can! labels Jan 28, 2017
@tomasko126
Copy link
Member

#1 is being addressed in #123, I will take a look at other issues asap.

@tomasko126 tomasko126 modified the milestone: 1.5.1 Jan 31, 2017
This was referenced Feb 12, 2017
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tomasko126 tomasko126

Labels
br-firefox This only affects Firefox bug This is a bug with the extension pr-high This is a high-priority issue. If you want to help out, try one of these if you can!
Projects
None yet
Milestone
1.5.1
2 participants
@itskdog @tomasko126