Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Manual Import and Mapping #124

Closed
Gandalf-the-Blue opened this issue Jan 9, 2024 · 8 comments
Closed

Allow Manual Import and Mapping #124

Gandalf-the-Blue opened this issue Jan 9, 2024 · 8 comments
Labels
enhancement Request for a feature or improvement

Comments

@Gandalf-the-Blue
Copy link

Is your feature request related to a problem? Please describe.
Sometimes auto import does not work with some issues/ volumes, i.e. it works 95% of the time, but not 100%
Having an additional manual import option where one can map the file to the issue would solve this issue.

Describe the solution you'd like
Have a manual import option that opens up a screen similar to sonarr/readarr/lidarr etc. where mapping is possible.

Additional context
NA

@Gandalf-the-Blue Gandalf-the-Blue added the enhancement Request for a feature or improvement label Jan 9, 2024
@Casvt
Copy link
Owner

Casvt commented Jan 9, 2024

Duplicate of #46.

But what are the scenarios that it doesn't match? Wouldn't mind making that 95% closer to 99%.

@Casvt Casvt closed this as not planned Won't fix, can't repro, duplicate, stale Jan 9, 2024
@Gandalf-the-Blue
Copy link
Author

Gandalf-the-Blue commented Jan 9, 2024

Hey @Casvt ,
I am having this problem on
Absolute Crisis on Infinite Earths
Absolute DC : The New Frontier
Action Comics (2011) - Certain Issues
Daytripper (2011)
etc.

I have also noticed that sometimes Kapowarr is able to detect and import the issue, but after some time, it says the issue is not there (even though it is, with Kapowarr's naming scheme) - this issue seems to be sort of random, and even fixes itself after an unspecified amount of time.

@Casvt
Copy link
Owner

Casvt commented Jan 9, 2024

Absolute Crisis on Infinite Earths

On GC the release is called "Crisis on Infinite Earths – The Absolute Edition (HC) (2005)" which doesn't match the CV title of "Absolute Crisis On Infinite Earths". On top, the issue title is "The Absolute Edition" which also doesn't match. So nothing matches. This would be a good case for manual file matching yes.

Absolute DC: The New Frontier

This is a hard cover without a release on GC. So I'd have to know what the filename is. But I know that in beta-4 (fixed in my local version already but not released yet), the filename needs to have 'hard cover' (or any version of it) in the filename in order to match. In the next release, issue number 1 or none at all is also allowed.

Action Comics (2011) - Certain Issues

Without telling me exactly which ones, I can't know. One thing I know though is that beta-4 has a bug where issues for issue 0 get mapped to the issue number with the same number as the volume number. So in the case of this volume, the file for issue 0 get's mapped to issue 2. That has been fixed of course, but you'll still encounter it. If there are any other issues in this volume with problems, you'll have to tell me which ones exactly.

Daytripper (2011)

Don't see anything wrong with this before I can see the filename. Files only match to a TPB volume like this one when they don't have an issue number in them. So if your file is named Daytripper Volume 1 Issue 1 The Deluxe Edition, or something like that, it won't match. But Daytripper Volume 1 The Deluxe Edition or Daytripper Volume 1 TPB will match.

@Gandalf-the-Blue
Copy link
Author

Absolute DC: The New Frontier - Adding Hard Cover worked here, thanks!
Daytripper - Was resolved by adding TPB to the issue, thanks!

For Action Comics (2011) - Issue 0 & 20 isn't getting mapped + Issues 31-34 (separate files) get mapped to Issue 1
The Flash (1987) - Issue 0, 109,110,132,136-141, 80-94 (single issue) - Aren't getting mapped properly.
and as you mentioned, the issue with Absolute Crisis on Infinite Earths persists.

@Casvt
Copy link
Owner

Casvt commented Jan 10, 2024

For Action Comics (2011) - Issue 0 & 20 isn't getting mapped + Issues 31-34 (separate files) get mapped to Issue 1
The Flash (1987) - Issue 0, 109,110,132,136-141, 80-94 (single issue) - Aren't getting mapped properly.

Seems that all these issues have to do with having 'Part' or 'Chapter' in the issue title. I believe I added handling for that, but I depends on the filename. Could you give an example filename of one of the issues?

@Gandalf-the-Blue
Copy link
Author

Gandalf-the-Blue commented Jan 10, 2024

Action Comics (2011) #00 - The Boy Who Stole Superman's Cape; Origin of the Species.cbr
Action Comics (2011) #31 - Infected Chapter 1 True Believers.cbr
Which is in line with Kapowarr's file naming - "{series_name} ({year}) #{issue_number} - {issue_title}" with issue padding of 0x
All of these are getting mapped to Issue 01

It seems as though when a refresh and scan is performed, Kapowarr doesn't parse filenames based on the user set file naming preference.

@Casvt
Copy link
Owner

Casvt commented Jan 10, 2024

Kapowarr doesn't care what the file format is when scanning for files. They're two completely different things. The mapping of Issue 0 to Issue {volume_number} is already fixed. Issue 31 being mapped to Issue 1 is because the title of the issue contains 'Chapter 1', which makes Kapowarr think that it's for Issue 1. I believe I added handling for that, but apparently it's not working well yet.

@Casvt
Copy link
Owner

Casvt commented Jan 10, 2024

Fixed it. The whole problem was that Kapowarr supported 'Chapter' as a keyword similar to 'Issue'. And this would mess up when the title contains the word 'chapter'. However, it's not very common to use 'Chapter' to signify the issue number of a volume, so I just removed support for 'Chapter' being an alternative to 'Issue'. And because of this the problem with 'Chapter' in the title is also resolved. 'c' is still allowed (e.g. 'v2c8' = Volume 2 Issue 8).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Request for a feature or improvement
Projects
None yet
Development

No branches or pull requests

2 participants