Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fully qualify table names on trigger invalidation caches #198

Closed
zenitraM opened this issue Feb 10, 2016 · 0 comments
Closed

Fully qualify table names on trigger invalidation caches #198

zenitraM opened this issue Feb 10, 2016 · 0 comments
Assignees

Comments

@zenitraM
Copy link
Contributor

Right now, as we generate the invalidation tags based on CDB_QueryTablesText output, we tag tables with:
schemaname.tablename
even if the schema name could be omitted. This is because CDB_QueryTables formats it explicitly:
https://github.com/CartoDB/cartodb-postgresql/blob/master/scripts-available/CDB_QueryTables.sql#L48+

However, when we call cdb_invalidate_varnish, we pass it a casted to text regclass, which might only be tablename if schemaname is first on the search path.

This works de chiripa as our regex is permissive enough on upper layers to invalidate X-Cache-Channel for schemaname.tablename when tablename is sent, but might break any invalidations which need strict matches such as Surrogate-Key's.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants