Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run Python examples during CI to catch breakages #60

Closed
ischoegl opened this issue Jul 11, 2020 · 1 comment
Closed

Run Python examples during CI to catch breakages #60

ischoegl opened this issue Jul 11, 2020 · 1 comment
Labels
feature-request New feature request

Comments

@ischoegl
Copy link
Member

Abstract

Work on 2.5 resulted in multiple Python examples being broken. It would be of value to add running of Python examples during CI (see also #37) to avoid inadvertent breakage or deprecation of functionality.

Possible Solutions

Simply running examples while filtering DeprecationWarnings as errors will reveal most issues (see closed PR Cantera/cantera#892). An alternative would be to build full regression tests comparing output to validated results.

References

Improvements to CI: #37
Limited implementation: Cantera/cantera#892
Regression tests for C++ Cantera/cantera#883 and FORTRAN Cantera/cantera#874
@ischoegl ischoegl added the feature-request New feature request label Jul 11, 2020
@ischoegl ischoegl mentioned this issue Jul 11, 2020
Closed
4 tasks
@ischoegl ischoegl changed the title Run Python examples during CI Run Python examples during CI to catch breakages Jul 11, 2020
@ischoegl ischoegl mentioned this issue Jul 29, 2020
Merged
4 tasks
@ischoegl
Copy link
Member Author

This is implemented in Cantera/cantera#905

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request New feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[CI] Run python examples from scons ischoegl/cantera
1 participant
@ischoegl