You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
At the moment, the FlameBase.to_solution_array method assembles a SolutionArray in Python instead of accessing the Domain1D::asArray serialization method of the C++ object. One consequence is that the output order of components is incorrect.
Motivation
Describe the need for the proposed change:
What problem is it trying to solve? ... remove/deprecate redundant code
Who is affected by the change? ... users of Cantera 3.0
Why is this a good solution? ... the conversion should use the same tools as the C++ save/restore methods
Possible Solutions
There are two options:
Implement Sim1D::asArray(const string& name) and link to FlameBase.to_solution_array; one complication is that the C++ route does not normalize, which is the current default behavior in Python.
Implement Domain1D::asArray() and link to a new Domain1D.to_solution_array; here, the complication is that Domain1D knows its container, but is is accessed as OneDim, which does not hold the solution vector; as in other instances, the code uses raw pointers internally, which ideally would have to be converted to smart pointers.
Abstract
At the moment, the
FlameBase.to_solution_array
method assembles aSolutionArray
in Python instead of accessing theDomain1D::asArray
serialization method of the C++ object. One consequence is that the output order of components is incorrect.Motivation
Describe the need for the proposed change:
Possible Solutions
There are two options:
Sim1D::asArray(const string& name)
and link toFlameBase.to_solution_array
; one complication is that the C++ route does not normalize, which is the current default behavior in Python.Domain1D::asArray()
and link to a newDomain1D.to_solution_array
; here, the complication is thatDomain1D
knows its container, but is is accessed asOneDim
, which does not hold the solution vector; as in other instances, the code uses raw pointers internally, which ideally would have to be converted to smart pointers.References
The text was updated successfully, but these errors were encountered: