Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up RedlichKwongMFTP #16

Open
decaluwe opened this issue Dec 30, 2019 · 2 comments
Open

Clean up RedlichKwongMFTP #16

decaluwe opened this issue Dec 30, 2019 · 2 comments
Labels
feature-request New feature request

Comments

@decaluwe
Copy link
Member

Abstract

With the (in-progress) addition of the PengRobinson class (Cantera/cantera#641), which largely parallels the RedlichKwongMFTP implementation, it is apparent that there are a number of updates and changes that would make the latter class more robust, easier to read, and overall more consistent with the rest of the Cantera codebase.

Description

  • Convert instances of doublereal to double
  • Update and/or fix some variable names for greater clarify and/or brevity
  • Add a test to the suite to evaluate the class calculations directly against the EoS (similar to PengRobison_Test::getPressure.
  • This is just a partial list. A thorough evaluation and scrubbing of the class is merited.
@decaluwe decaluwe added the work-in-progress An enhancement that someone is currently working on label Dec 30, 2019
@bryanwweber
Copy link
Member

@decaluwe What's the status of this with respect to Cantera/cantera#641? Is there more to do related to this issue? Can it be closed?

@decaluwe
Copy link
Member Author

decaluwe commented Apr 5, 2021

I am guessing it is incomplete. @gkogekar may have addressed some of these in creating some functionality at the MixtureFugacityTP level, but other than that I'm not sure much has been done, here. I certainly would not close it, at this point. I'll try and take a look in the coming weeks.

@bryanwweber bryanwweber added feature-request New feature request and removed work-in-progress An enhancement that someone is currently working on labels May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request New feature request
Projects
None yet
Development

No branches or pull requests

2 participants