You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe
The implementation of falloff reactions separates falloff and chemically-activated reactions (a relatively minor binary distinction) while introducing a FalloffFactory. This solution (while historical) appears to be more complex than necessary.
Describe the desired solution
Removal of FalloffFactory simplifies the reaction structure by explicitly specifying three falloff variants, i.e. falloff-Lindemann, falloff-Troe, and falloff-SRI. Further, it is sufficient to define chemically-activated as a boolean field (that defaults to false).
The current YAML implementation differentiates the falloff types based on the existence of SRI or Troe fields. A refactoring of the C++ code does not depend on a change of the YAML syntax.
Additional context
Change of YAML and refactoring of C++ code is independent. PR #745 creates a basis for easy adoption of the alternative reaction definition. As YAML is not yet officially released, the syntax modification can be easily incorporated into 2.5.
The text was updated successfully, but these errors were encountered:
Closing this as I don't think it is necessary as described (flattening the structure has no significant benefits, as it's easy to interpret the current implementation as type and subtype).
I still believe that there isn't a good reason to differentiate between falloff and chemically-activated, as the difference is marginal and does not warrant maintaining two separate classes. I will open another issue on this eventually.
Is your feature request related to a problem? Please describe
The implementation of falloff reactions separates
falloff
andchemically-activated
reactions (a relatively minor binary distinction) while introducing aFalloffFactory
. This solution (while historical) appears to be more complex than necessary.Describe the desired solution
Removal of
FalloffFactory
simplifies the reaction structure by explicitly specifying three falloff variants, i.e.falloff-Lindemann
,falloff-Troe
, andfalloff-SRI
. Further, it is sufficient to definechemically-activated
as a boolean field (that defaults tofalse
).Describe alternatives you have considered
The current YAML implementation differentiates the falloff types based on the existence of
SRI
orTroe
fields. A refactoring of the C++ code does not depend on a change of the YAML syntax.Additional context
Change of YAML and refactoring of C++ code is independent. PR #745 creates a basis for easy adoption of the alternative reaction definition. As YAML is not yet officially released, the syntax modification can be easily incorporated into 2.5.
The text was updated successfully, but these errors were encountered: