Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create consistent approach for FlowDevice parameters/functions #666

Closed
ischoegl opened this issue Jul 1, 2019 · 0 comments · Fixed by #667
Closed

Create consistent approach for FlowDevice parameters/functions #666

ischoegl opened this issue Jul 1, 2019 · 0 comments · Fixed by #667

Comments

@ischoegl
Copy link
Member

ischoegl commented Jul 1, 2019

Cantera version

2.4.0 / 2.5.0a3

Operating System / Python/MATLAB version

all

Expected Behavior

FlowDevice objects should use a consistent philosophy for the implementation of parameters. I.e. MassFlowController, PressureController and Valve. Function names should be representative of actual behavior. MATLAB and Python implementations should use the same approach.

Actual Behavior

The implementation of FlowDevice objects is not consistent and even differs between Python and MATLAB. Python does not use the vector m_coeffs whereas MATLAB can set an array of values that cannot be used by the underlying C++ code. FlowDevice::updateMassFlowRate function signatures take time as an argument, which is not implemented for Valve objects (which precludes the implementation of time-dependent switching valves).

Some function names in the python interface are misleading (Valve.set_pressure_coeff). Python and MATLAB implementations differ (FlowDevice::setParameters).

Steps to reproduce

  1. N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants