Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'KineticsAddSpecies.add_species_sequential' test failed #367

Closed
sagitter opened this issue Oct 15, 2016 · 3 comments
Closed

'KineticsAddSpecies.add_species_sequential' test failed #367

sagitter opened this issue Oct 15, 2016 · 3 comments

Comments

@sagitter
Copy link

sagitter commented Oct 15, 2016

Hello.

KineticsAddSpecies.add_species_sequential is failed with these errors:

[ RUN      ] KineticsAddSpecies.add_species_sequential
test/kinetics/kineticsFromScratch.cpp:427: Failure
Value of: w[i]
  Actual: 217.99038879671906
Expected: w_ref[iref]
Which is: 217.99038879671923
sp = H2O2; N = 4
test/kinetics/kineticsFromScratch.cpp:427: Failure
Value of: w[i]
  Actual: 248034692.62737739
Expected: w_ref[iref]
Which is: 248034692.62737754
sp = H2; N = 5
test/kinetics/kineticsFromScratch.cpp:427: Failure
Value of: w[i]
  Actual: 248033565.55450577
Expected: w_ref[iref]
Which is: 248033565.55450591
sp = O2; N = 5
[  FAILED  ] KineticsAddSpecies.add_species_sequential (130 ms)

Full log: https://kojipkgs.fedoraproject.org//work/tasks/2418/16092418/build.log

Cantera is built on a Enterprise Linux 7 system (Fedora, EPEL7), PowerPC64le architecture with this software: https://kojipkgs.fedoraproject.org//work/tasks/2418/16092418/root.log

@speth
Copy link
Member

speth commented Oct 15, 2016

This may be a bit challenging to fix, since this error doesn't occur on any of the platforms where I regularly compile Cantera, and I don't have access to a machine that uses the POWER8 architecture. This isn't a test where I would expect platform-specific failures -- the set of actual rate calculations done for each half of the comparison should be identical, and I'm hesitant to just allow an inexact comparison here without digging into it a bit.

I modified the test cases to make some additional checks. If you can provide the output of running the test suite for the current version (50d0f99), it might help a bit. Some other information that would be helpful:

  • What other platforms/architectures are packages being built for, and are there any issues with any of them?
  • Has the test suite been running successfully previously on this platform? If so, can you identify the commit where the test started failing?
  • How are these builds being run? Is this automated off of Github/master, or are they triggered manually? Are the build logs for all platforms available? Is there a way to trigger builds for a branch or PR (i.e. without making new commits to master)?

@sagitter
Copy link
Author

Let me do some tests.

@speth
Copy link
Member

speth commented Dec 18, 2016

@sagitter Unless you can provide some more details about this, I'm inclined to close this bug on the basis of it being unreproducible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants