Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makefile on Windows #1376

Closed
ischoegl opened this issue Aug 25, 2022 · 1 comment · Fixed by #1380
Closed

Makefile on Windows #1376

ischoegl opened this issue Aug 25, 2022 · 1 comment · Fixed by #1380
Labels
compiling Examples Windows

Comments

@ischoegl
Copy link
Member

ischoegl commented Aug 25, 2022 •
edited
Loading

Problem description

While Makefile's for C++ samples are installed on windows builds (via scons build && scons install), Cantera.mak is missing from the folder representing Cantera's include path (which is where it is installed on Linux systems)

C++ headers                 C:\Users\ischo\miniconda3\envs\cantera-dev\Library\include

To resolve, either (1) Makefile's should be omitted on Windows, or (2) Cantera.mak needs to be installed.

System information

  • Cantera version: 3.0.0a2
  • OS: Windows 10
  • VS2022
  • standard Cantera build in conda environment
@ischoegl
Copy link
Member Author

Per SO discussion, there does not appear to be a standard way to install GNU make on a windows system. I believe that it would make sense to remove Makefile's from Windows builds.

@ischoegl ischoegl mentioned this issue Aug 27, 2022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compiling Examples Windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[samples] Do not install Makefile's on Windows ischoegl/cantera
1 participant
@ischoegl