-
-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Undeclared duplicate reaction error for generic third body reaction matching the form of another reaction #1193
Comments
@corykinney ... as of Cantera 2.6, these reactions are indeed treated as duplicates (which is imho the correct behavior). The change was introduced in #1015. |
@ischoegl ... I was unsure of whether this was a bug or not and didn't realize this was intentionally added recently! What was the behavior prior to this change? I suppose to resolve this one of the conflicting reactions would have to be removed from the input mechanism, correct? What would be the best practice to ensure that the mechanism behaves in Cantera the same way it would behave in CHEMKIN? |
@corykinney add "duplicate" declaration to both reactions and set the collider efficiency to zero for O2 in the "+M" reaction if not already provided. If there is a non-zero efficiency, then the original intention seems ambiguous to me. |
@mefuller The original reaction is:
I'm not familiar with modifying CHEMKIN files, so just to verify, I'm assuming the modified version would be:
Is that correct? Also @ischoegl should we close this since I was mistaken and it's not an actual bug? EDIT: It seems that marking it with |
@corykinney If I recall the CHEMKIN syntax, the |
@bryanwweber the conversion/validation ended up passing after I added the collider efficiency of zero, even without the |
@corykinney No, if the collider efficiency is set to zero you don't need If you can, you may want to print out the rate of these two reactions from CHEMKIN as a function of temperature and pressure and see how that compares to the various valid Cantera options. |
@corykinney ... I don't think that this is a bug, and I agree with @mefuller's advice. One alternative would be to take the YAML output (ignoring the validation failure) and add the duplicate declaration there. |
PS: fwiw, there is some ongoing discussion on handling of duplicate reactions, see Cantera/enhancements#132 ... so feel free to comment there. |
Have you solved this problem? I have the same problem and I would like to ask you for your solution. |
The handling of reactions like this was changed in #1736: The default behavior is now to warn about such reactions (rather than raising an exception). A new |
Problem description
Sorry for the title wording, but essentially I've come across a valid CHEMKIN mechanism that includes the following two reactions:
and
Cantera views these as duplicate reactions because the former is a generalization of the latter, where
O2
is substituted forM
. I'm not sure how CHEMKIN handles these, but perhaps the more specific reaction is preferred over the general third body reaction when such a reaction is defined.Steps to reproduce
ck2yaml
with--permissive
for duplicate thermo and transport definitionsSystem information
Attachments
GitHub doesn't support uploading
.yaml
files, so here is the.txt
file of the converted mechanism that I'm using:NUIGMech1.1.txt
The text was updated successfully, but these errors were encountered: