Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken example CI runs #1132

Closed
ischoegl opened this issue Oct 24, 2021 · 3 comments
Closed

Broken example CI runs #1132

ischoegl opened this issue Oct 24, 2021 · 3 comments
Labels

Comments

@ischoegl
Copy link
Member

ischoegl commented Oct 24, 2021

Problem description

An apparent upstream change causes LaTeX \Delta no longer to be recognized in matplotlib figure titles. As a result, current GH Actions for Example tests are broken.

Steps to reproduce

See #1127. Error message is:

interfaces/cython/cantera/examples/kinetics/blowers_masel.py
Traceback (most recent call last):
  File "/opt/hostedtoolcache/Python/3.9.7/x64/lib/python3.9/site-packages/matplotlib/_mathtext.py", line 2277, in parse
    result = self._expression.parseString(s)
  File "/opt/hostedtoolcache/Python/3.9.7/x64/lib/python3.9/site-packages/pyparsing/core.py", line 1101, in parse_string
    raise exc.with_traceback(None)
pyparsing.exceptions.ParseFatalException: Unknown symbol: \Delta, found '\'  (at char 0), (line:1, col:1)

System information

GH Actions

Additional context

Avoiding LaTeX in examples is likely the easiest resolution (e.g. fix in #1129)

@speth
Copy link
Member

speth commented Oct 25, 2021

This has already been reported (matplotlib/matplotlib#21463) and fixed (matplotlib/matplotlib#21454) in Matplotlib. Arguably the easiest resolution is to just wait for the next bugfix release of Matplotlib, at which point this will just go away on its own.

@ischoegl
Copy link
Member Author

ischoegl commented Oct 26, 2021

@12Chao just proposed an alternative fix in #1038, but letting it go away is maybe the best option as the LaTeX string is actually legitimate.

@ischoegl
Copy link
Member Author

ischoegl commented Nov 9, 2021

As anticipated by @speth, the issue is fixed by an upstream update of matplotlib.

@ischoegl ischoegl closed this as completed Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants