Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STI normalizer fails when existing rule conditions are relation #794

Closed
adzap opened this issue Jul 4, 2022 · 2 comments
Closed

STI normalizer fails when existing rule conditions are relation #794

adzap opened this issue Jul 4, 2022 · 2 comments
Labels
gist needed

Comments

@adzap
Copy link

adzap commented Jul 4, 2022

See

cancancan/lib/cancan/model_adapters/sti_normalizer.rb

Line 34 in 959eee1

rule.conditions.merge(subject.inheritance_column => subject.sti_name), rule.block)

The merge presumes a hash of conditions but this raises error if the conditions are a relation.
@adzap adzap changed the title STI normalizer fails when existing rule conditions are relation. STI normalizer fails when existing rule conditions are relation Jul 4, 2022
@adzap
Copy link
Author

adzap commented Mar 7, 2023

I think this has been fixed in #702 . will verify.

@adzap
Copy link
Author

adzap commented Mar 10, 2023

Fixed by #702

@adzap adzap closed this as completed Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
gist needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@adzap @coorasse