fix: issues with invoices #271

cameri · 2023-03-28T02:44:15Z

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Non-functional change (docs, style, minor refactor)
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my code changes.
All new and existing tests passed.

coveralls · 2023-03-28T04:01:47Z

Pull Request Test Coverage Report for Build 4638676897

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

27 of 50 (54.0%) changed or added relevant lines in 9 files are covered.
98 unchanged lines in 15 files lost coverage.
Overall coverage decreased (-4.2%) to 50.678%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/handlers/request-handlers/root-request-handler.ts	0	1	0.0%
src/handlers/subscribe-message-handler.ts	4	5	80.0%
src/utils/secret.ts	3	4	75.0%
src/controllers/invoices/post-invoice-controller.ts	0	2	0.0%
src/utils/event.ts	11	13	84.62%
src/app/maintenance-worker.ts	0	4	0.0%
src/handlers/event-message-handler.ts	5	9	55.56%
src/services/payments-service.ts	3	11	27.27%

Files with Coverage Reduction	New Missed Lines	%
src/handlers/request-handlers/root-request-handler.ts	1	12.5%
src/repositories/event-repository.ts	1	97.44%
src/services/payments-service.ts	1	6.45%
src/app/maintenance-worker.ts	2	0.0%
src/handlers/event-strategies/replaceable-event-strategy.ts	2	84.62%
src/adapters/web-server-adapter.ts	3	56.67%
src/app/worker.ts	3	34.29%
src/handlers/event-message-handler.ts	3	82.69%
src/factories/rate-limiter-factory.ts	4	45.45%
src/utils/settings.ts	4	65.82%

Totals
Change from base Build 4343993912:	-4.2%
Covered Lines:	1117
Relevant Lines:	2135

💛 - Coveralls

resources/invoices.html

src/app/maintenance-worker.ts

antonleviathan · 2023-04-05T12:23:07Z

src/handlers/event-message-handler.ts

      return
    }

+    if (this.getRelayPublicKey() === event.pubkey) {
+      return undefined


Inconsistent returns, is this intentional?

this is fine, we return undefined if user is admitted/whitelisted or a string with the reason if they are not admitted

this new check fixes the issue of the relay's public key not being allowed on the relay when payment is enabled which is a big oversight

in the future we could change this pattern to using constants or symbols

Ah got it, I was referring more to line 261 vs line 265, cause one is just return and the other return undefined

Ah, I'll remove the extra undefined

src/services/payments-service.ts

antonleviathan · 2023-04-05T12:27:22Z

src/utils/event.ts

@@ -181,15 +181,33 @@ export const identifyEvent = async (event: UnidentifiedEvent): Promise<UnsignedE
  return { ...event, id }
 }

-export function getRelayPrivateKey(relayUrl: string): string {
+let privateKeyCache: string | undefined
+export function getRelayPrivateKey(secret: string): string {


Is secret an optional parameter? If so we could make the type indicate this

it should always be the relay's URL, but it is ignored when RELAY_PRIVATE_KEY env var is set

Ok, why is the param called secret?

src/utils/event.ts

sonarqubecloud · 2023-04-07T16:04:54Z

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

49.4% Coverage
0.0% Duplication

# [1.23.0](v1.22.6...v1.23.0) (2023-05-12) ### Bug Fixes * add SECRET as env variable ([#298](#298)) ([58a1254](58a1254)) * invoice auto marked as paid ([be6d6f1](be6d6f1)) * issues with invoices ([#271](#271)) ([e1561e7](e1561e7)) ### Features * add LNURL processor ([#202](#202)) ([f237400](f237400)) * allow lightning zap receipts on paid relays ([#303](#303)) ([14bc96f](14bc96f))

github-actions · 2023-05-12T23:58:53Z

🎉 This PR is included in version 1.23.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

# [1.23.0](v1.22.6...v1.23.0) (2023-05-12) ### Bug Fixes * add SECRET as env variable ([#298](#298)) ([58a1254](58a1254)) * invoice auto marked as paid ([be6d6f1](be6d6f1)) * issues with invoices ([#271](#271)) ([e1561e7](e1561e7)) ### Features * add LNURL processor ([#202](#202)) ([f237400](f237400)) * allow lightning zap receipts on paid relays ([#303](#303)) ([14bc96f](14bc96f))

* chore: hide powered by zebedee if payment processor is not * chore: add nodeless as payments processor to settings * fix: bad content type on zebedee callback req handler * chore(release): 1.23.0 [skip ci] # [1.23.0](v1.22.6...v1.23.0) (2023-05-12) ### Bug Fixes * add SECRET as env variable ([#298](#298)) ([58a1254](58a1254)) * invoice auto marked as paid ([be6d6f1](be6d6f1)) * issues with invoices ([#271](#271)) ([e1561e7](e1561e7)) ### Features * add LNURL processor ([#202](#202)) ([f237400](f237400)) * allow lightning zap receipts on paid relays ([#303](#303)) ([14bc96f](14bc96f)) * feat: implement nodeless payments processor * docs: add accepting payments section * chore: validate nodeless webhook secret * chore: hide powered-by-zebedee for non-zebedee processors --------- Co-authored-by: semantic-release-bot <semantic-release-bot@martynus.net>

# [1.24.0](v1.23.0...v1.24.0) (2023-05-15) ### Features * implement nodeless payments processor ([#305](#305)) ([52aac39](52aac39)), closes [#298](#298) [#271](#271) [#202](#202) [#303](#303)

cameri added 2 commits March 27, 2023 22:42

fix: issues with invoices

9d9e8d2

chore: add invoice event tag

22371ec

chore: add sub limits

c0cb262

cameri requested review from Semisol and antonleviathan April 4, 2023 19:38

antonleviathan reviewed Apr 4, 2023

View reviewed changes

resources/invoices.html Outdated Show resolved Hide resolved

antonleviathan reviewed Apr 4, 2023

View reviewed changes

src/app/maintenance-worker.ts Outdated Show resolved Hide resolved

cameri added 3 commits April 4, 2023 18:35

chore: cleanup invoices page

3abc209

chore: use mergeDeepLeft when updating invoice

fe41d7c

chore: ignore whitelisted pubkey for adminssion fee

8557bb5

cameri requested a review from bmewj April 4, 2023 22:53

antonleviathan reviewed Apr 5, 2023

View reviewed changes

src/services/payments-service.ts Outdated Show resolved Hide resolved

antonleviathan reviewed Apr 5, 2023

View reviewed changes

src/utils/event.ts Outdated Show resolved Hide resolved

cameri added 7 commits April 5, 2023 08:33

chore: use secp256k1 bytesToHex

08d1221

fix: insecure derivation from secret

98c4424

fix: tests

7baa6d6

chore: consistent returns

05c0891

test: fix intg tests

df67a64

fix: intg tests

77cf759

chore: set SECRET for intg tests

3ad0d32

cameri merged commit e1561e7 into main Apr 7, 2023

cameri deleted the fix/invoice-page branch April 7, 2023 16:48

github-actions bot added the released label May 12, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: issues with invoices #271

fix: issues with invoices #271

cameri commented Mar 28, 2023

coveralls commented Mar 28, 2023 •

edited

Loading

antonleviathan Apr 5, 2023

cameri Apr 5, 2023

cameri Apr 5, 2023

antonleviathan Apr 5, 2023

cameri Apr 7, 2023

antonleviathan Apr 5, 2023

cameri Apr 5, 2023

antonleviathan Apr 5, 2023

sonarqubecloud bot commented Apr 7, 2023

github-actions bot commented May 12, 2023

fix: issues with invoices #271

fix: issues with invoices #271

Conversation

cameri commented Mar 28, 2023

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

coveralls commented Mar 28, 2023 • edited Loading

Pull Request Test Coverage Report for Build 4638676897

Warning: This coverage report may be inaccurate.

Details

💛 - Coveralls

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sonarqubecloud bot commented Apr 7, 2023

github-actions bot commented May 12, 2023

coveralls commented Mar 28, 2023 •

edited

Loading