Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing schedule after a programme is uploaded can leave .liq files hanging around #18

Open
dnas2 opened this issue Jan 18, 2023 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@dnas2
Copy link
Contributor

dnas2 commented Jan 18, 2023

If the following occurs:

  1. ProgrammeA is in the schedule
  2. ProgrammeA is uploaded and the corresponding .liq file is created
  3. ProgrammeA is replaced by ProgrammeB in the schedule
  4. ProgrammeA's MP3 file gets deleted from the server
  5. ProgrammeB is uploaded and the corresponding .liq file is created

Then there will be two .liq files for the same time. The earlier PID alphabetically has precedence, so if ProgrammeA's PID is alphabetically before ProgrammeB, we will get a silence detect as the file has been deleted.
Solution is to check in checkFilePresent.py that if there are .liqs with no corresponding .mp3, the .liq gets deleted
Worst case, if we delete too many .liqs, they'll get recreated by makeSchedule.py a couple of mins later

@dnas2 dnas2 added the bug Something isn't working label Jan 18, 2023
@dnas2 dnas2 self-assigned this Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant