Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect example in README #57

Closed
jatkinson1000 opened this issue Oct 31, 2023 · 0 comments · Fixed by #60
Closed

Incorrect example in README #57

jatkinson1000 opened this issue Oct 31, 2023 · 0 comments · Fixed by #60
Labels
bug Something isn't working documentation Improvements or additions to documentation

Comments

@jatkinson1000
Copy link
Member

Related to #56 The example code in the README is now incorrect as it has not incorporated the updates to use the layout argument in torch_tensor_from_blob()

We should either:

  • Update it to use t_t_from_array()
  • Update to add a layout argument

My preference is for the first (see discussion on #56).

However, this information should also be taken out of the README and placed in the longer form API docs now, perhaps as part of #53

@jatkinson1000 jatkinson1000 added bug Something isn't working documentation Improvements or additions to documentation labels Oct 31, 2023
@jatkinson1000 jatkinson1000 added this to the Initial Release milestone Oct 31, 2023
@jatkinson1000 jatkinson1000 linked a pull request Nov 18, 2023 that will close this issue
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant