Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Constant recomposing #47

Closed
fergdev opened this issue Aug 31, 2024 · 3 comments
Closed

Constant recomposing #47

fergdev opened this issue Aug 31, 2024 · 3 comments

Comments

@fergdev
Copy link

fergdev commented Aug 31, 2024 •
edited
Loading

When scrolling using the second example (Complete Example (with haptic feedback)) in README.md the ReorderableItem and ReorderableItemScope constantly recomposes. Is this expected behaviour?

Removing the ReorderableItem returns recomposition to standard behaviour.

This is impacting performance on a few screens of mine.

Screen.Recording.2024-08-31.at.6.04.50.PM.mov

Thanks, love the library, hope to keep using it.
@Calvin-LL
Copy link
Owner

Oh I'll take a look tomorrow PST

@fergdev fergdev mentioned this issue Aug 31, 2024
Closed
Repository owner deleted a comment Aug 31, 2024
@Calvin-LL
Copy link
Owner

try v2.3.2

@fergdev
Copy link
Author

fergdev commented Sep 1, 2024

Much better performance on the demo :) thanks for that. Now I just have to figure out why my list is slow. I'll raise another bug if I get a simple example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fergdev @Calvin-LL