Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: pre_uninstall and post_uninstall fields missing from sortJSON lists in settings.json #1183

Closed
mundifex opened this issue Jul 5, 2024 · 0 comments · Fixed by #1184
Closed
Labels
bug Something isn't working

Comments

@mundifex
Copy link
Contributor

mundifex commented Jul 5, 2024

Running the Sort JSON command against manifest containing either the pre_uninstall or post_uninstall fields may result in unintended modifications to a properly sorted manifest.

For example, running Sort JSON against bloxstrap.json moves the pre_uninstall block below autoupdate which does not adhere to the desired field order as described in CONTRIBUTING.md.

Adding these fields to the list of fields in settings.json should correct this issue.

@mundifex mundifex changed the title pre_uninstall and post_uninstall fields missing from sortJSON lists in settings.json [Bug]: pre_uninstall and post_uninstall fields missing from sortJSON lists in settings.json Jul 5, 2024
@Calinou Calinou added the bug Something isn't working label Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants