Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advanced File Field 2.0 #9

Open
Shelob9 opened this issue Jul 17, 2018 · 1 comment
Open

Advanced File Field 2.0 #9

Shelob9 opened this issue Jul 17, 2018 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@Shelob9
Copy link
Contributor

Shelob9 commented Jul 17, 2018

Overview

A React component built using:

This will allow for upload to our small caldera-file-service microservice app that acts as an s3 proxy. Configuration options MUST be the same as CF 1.x advanced file field so that customers can easily switch to new version.

How Field Works

Two Options:

The system should be designed to take the same config array that a current advanced file field takes. We can extend that schema if we need to. The validation of the schema/ prop shape should be done here:
https://github.com/CalderaWP/caldera-components/blob/master/src/components/fields/factories

Either way, our goal is to add to the @caldera-labs/components a wrapper for an existing s3 React component that has its props mapped to the same shape as a current CF Adv file field.

The new field would need to be wrapped in @caldera-labs/components FieldGroup

@Shelob9
Copy link
Contributor Author

Shelob9 commented Jul 17, 2018

Please submit a pull request using branch feature/9 and request a final code review when test coverage is no less than it is now (Coveralls will make comments on the PR) and no new code smells are introduced (CodeClimate will add comments to the PR)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants