From a082f37bd3129d2f479f3a8992db53c2fa85e6c3 Mon Sep 17 00:00:00 2001
From: TheWitness <thewitness@cacti.net>
Date: Sat, 21 Jan 2023 10:26:29 -0500
Subject: [PATCH] Improve solution around #5161

This will make sure a refresh happens when any of the three values change.  Should be good enough.
---
 settings.php | 22 ++++++++++++++--------
 1 file changed, 14 insertions(+), 8 deletions(-)

diff --git a/settings.php b/settings.php
index ae5c75205d..fab3e7582a 100644
--- a/settings.php
+++ b/settings.php
@@ -477,7 +477,7 @@
 	<script type='text/javascript'>
 
 	var themeChanged   = false;
-	var langChanged    = false;
+	var langRefresh    = false;
 	var currentTheme   = '';
 	var currentLang    = '';
 	var rrdArchivePath = '';
@@ -506,7 +506,7 @@
 				return false;
 			}
 
-			if (themeChanged == true || langChanged == true) {
+			if (themeChanged == true || langRefresh == true) {
 				$.post('settings.php?tab='+$('#tab').val()+'&header=false', $('input, select, textarea').prop('disabled', false).serialize()).done(function(data) {
 					document.location = 'settings.php?newtheme=1&tab='+$('#tab').val();
 				});
@@ -519,8 +519,10 @@
 		});
 
 		if (currentTab == 'general') {
-			currentPerms = $('#graph_auth_method').val();
-			currentLang  = $('#i18n_auto_detection').val();
+			currentPerms       = $('#graph_auth_method').val();
+			currentLangDetect  = $('#i18n_auto_detection').val();
+			currentLanguage    = $('#i18n_default_language').val();
+			currentLangSupport = $('#i18n_language_support').val();
 
 			$('#selective_plugin_debug').multiselect({
 				menuHeight: $(window).height()*.7,
@@ -570,7 +572,7 @@
 				permsChanger();
 			});
 
-			$('#i18n_auto_detection').change(function() {
+			$('#i18n_default_language, #i18n_auto_detection, #i18n_language_support').change(function() {
 				langDetectionChanger();
 			});
 		} else if (currentTab == 'spikes') {
@@ -868,10 +870,14 @@ function themeChanger() {
 	}
 
 	function langDetectionChanger() {
-		if ($('#i18n_auto_detection').val() != currentLang) {
-			langChanged = true;
+		var changed = currentLanguage != $('#i18n_default_language').val() ||
+			currentLangDetect         != $('#i18n_auto_detection').val() ||
+			currentLangSupport        != $('#i18n_language_support').val();
+
+		if (changed) {
+			langRefresh = true;
 		} else {
-			langChanged = false;
+			langRefresh = false;
 		}
 	}