Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pauli propagation use case example #333

Merged
merged 28 commits into from
May 3, 2024
Merged

feat: pauli propagation use case example #333

merged 28 commits into from
May 3, 2024

Conversation

ss2165
Copy link
Member

@ss2165 ss2165 commented May 3, 2024

Add bindings to emulate python builder - intent is to replace this with a pure python builder.

Add "CircuitBuilder" like utilities to assist appending operations to qubits.

Use the above to demonstrate pauli propagation through a circuit using exhaustive rewrite rule application.

  • Add some type annotations for circuit bindings, should ideally be replicated for other modules

@ss2165 ss2165 requested a review from aborgna-q May 3, 2024 14:18
Copy link

codecov bot commented May 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.02%. Comparing base (2f1d1a1) to head (ef8251a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #333      +/-   ##
==========================================
+ Coverage   84.99%   85.02%   +0.02%     
==========================================
  Files          35       36       +1     
  Lines        4444     4553     +109     
  Branches     4292     4292              
==========================================
+ Hits         3777     3871      +94     
- Misses        487      503      +16     
+ Partials      180      179       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@aborgna-q aborgna-q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome.

We'll rework this interface soon™, but this is a cool proof of concept for the API.

"""A Tket2 built-in operation."""

H = 1
CX = 2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add all the others? At least the ones that appear in build.py.

Suggested change
CX = 2
CX = auto()
T = auto()
S = auto()
X = auto()
Y = auto()
Z = auto()
Tdg = auto()
Sdg = auto()
ZZMax = auto()
Measure = auto()
RzF64 = auto()
RxF64 = auto()
PhasedX = auto()
ZZPhase = auto()
AngleAdd = auto()
CZ = auto()
TK1 = auto()
QAlloc = auto()
QFree = auto()
Reset = auto()

It's annoying that the values are required. They do not exist on the rust side.

Comment on lines 85 to 101
# Some common operations

QAlloc = CustomOp("quantum.tket2", "QAlloc", [], [QB_T])
QFree = CustomOp("quantum.tket2", "QFree", [QB_T], [])
Measure = CustomOp("quantum.tket2", "Measure", [QB_T], [QB_T, BOOL_T])
Not = CustomOp("logic", "Not", [BOOL_T], [BOOL_T])


@dataclass(frozen=True)
class H(Command):
qubit: int
gate_name = "H"
n_qb = 1

def qubits(self) -> list[int]:
return [self.qubit]

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a bit of a mix here of Operations with no corresponding command, and commands with no first-level operation definition.

No need to actually add them here since this is a prototype, but maybe add a comment mentioning the difference?

@ss2165 ss2165 added this pull request to the merge queue May 3, 2024
Merged via the queue into main with commit f46973c May 3, 2024
11 checks passed
@ss2165 ss2165 deleted the feat/circ-build branch May 3, 2024 15:14
github-merge-queue bot pushed a commit that referenced this pull request Jun 28, 2024
🤖 I have created a release *beep* *boop*
---


## 0.1.0 (2024-06-28)


### ⚠ BREAKING CHANGES

* require `hugr-0.5.0`
* Replaced `tket2.circuit.OpConvertError` with
`tket2.circuit.TK1ConvertError` in the python lib.
* Moved `tket2::json` to `tket2::serialize::pytket`
* Replaced the `Circuit` trait with a wrapper struct.
* This is a breaking change to the compiled rewriter serialisation
format.

### Features

* Add a "progress timeout" to badger
([#259](#259))
([556cf64](556cf64))
* Add missing typing hints
([#352](#352))
([4990613](4990613))
* bindings for circuit cost and hash
([#252](#252))
([85ce5f9](85ce5f9))
* drop pyo3 core dep ([#355](#355))
([9f7d415](9f7d415))
* EccRewriter bindings
([#251](#251))
([97e2e0a](97e2e0a))
* guppy → pytket conversion
([#407](#407))
([8c5a487](8c5a487))
* Implement `PyErr` conversion locally in `tket2-py`
([#258](#258))
([3e1a68d](3e1a68d))
* init tket2-hseries ([#368](#368))
([61e7535](61e7535))
* pauli propagation use case example
([#333](#333))
([f46973c](f46973c))
* **py:** Allow using `Tk2Op`s in the builder
([#436](#436))
([aed8651](aed8651))
* Support any ops in portmatching
([#293](#293))
([6b05a05](6b05a05))
* **tket2-py:** Bind the `lower_to_pytket` pass in python
([#439](#439))
([8208324](8208324))
* Use tket1 and tket2 circuits interchangeably everywhere
([#243](#243))
([eac7acf](eac7acf))
* Utilities for loading compiled guppy circuits
([#393](#393))
([028779a](028779a))


### Bug Fixes

* failed importlib import
([#254](#254))
([b077660](b077660))
* induced cycles in depth optimisation
([#264](#264))
([68c9ff2](68c9ff2)),
closes [#253](#253)
* Make native py modules behave like python's
([#212](#212))
([4220038](4220038)),
closes [#209](#209)
* pytest failing to find `tket2` in CI
([#367](#367))
([a9df8e6](a9df8e6))
* **tket2-py:** Replace `with_hugr` helpers with `with_circ`, keeping
the circuit parent. ([#438](#438))
([b77b3cb](b77b3cb))


### Documentation

* Add some example notebooks for the python package.
([#443](#443))
([4ed276c](4ed276c)),
closes [#434](#434)
* Update tket2-py readme
([6c8f18a](6c8f18a))


### Code Refactoring

* Rename `tket2::json` into `tket2::serialize::pytket`
([#392](#392))
([93e611c](93e611c))
* Replace Circuit trait with a struct
([#370](#370))
([ec5dd22](ec5dd22))
* Simplify tket1 conversion errors
([#408](#408))
([b0b8aff](b0b8aff))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: Agustin Borgna <agustin.borgna@quantinuum.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants