Skip to content

Commit

Permalink
ci: Fix release wheels if condition (#394)
Browse files Browse the repository at this point in the history
The `if` condition that decided whether to publish to pypi always
evaluate to `true` -.-

I'm still not sure why; I suspected the trailing `||` but I tested many
variations and only this github expression in a single line worked as
expected...
https://github.com/CQCL/tket2/actions/runs/9418704582/job/25947230967
  • Loading branch information
aborgna-q committed Jun 7, 2024
1 parent 093e650 commit 51e3e2a
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions .github/workflows/python-wheels.yml
Original file line number Diff line number Diff line change
Expand Up @@ -127,9 +127,7 @@ jobs:
release:
name: Release
runs-on: ubuntu-latest
if: |
${{ (github.event_name == 'release' && github.ref_type == 'tag' && startsWith(github.ref, 'refs/tags/tket2-py-v'))}} ||
${{ (github.event_name == 'workflow_dispatch' && github.ref_type == 'tag' && startsWith(github.ref, 'refs/tags/tket2-py-v'))}} ||
if: ${{ (github.event_name == 'release' && github.ref_type == 'tag' && startsWith(github.ref, 'refs/tags/tket2-py-v') ) || (github.event_name == 'workflow_dispatch' && github.ref_type == 'tag' && startsWith(github.ref, 'refs/tags/tket2-py-v') ) }}
needs: [linux, windows, macos, sdist]
steps:
- uses: actions/download-artifact@v4
Expand Down

0 comments on commit 51e3e2a

Please sign in to comment.