Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Combine ExtensionSolutions (no separate closure) #884

Merged
merged 20 commits into from
Apr 9, 2024
Merged

refactor: Combine ExtensionSolutions (no separate closure) #884

merged 20 commits into from
Apr 9, 2024

Commits on Mar 18, 2024

  1. Combine ExtensionSolutions (no separate closure)

    @acl-cqc
    acl-cqc committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    95e40ad View commit details
    Browse the repository at this point in the history

  2. Do first main_loop (it mutates ctx, and may throw)

    @acl-cqc
    acl-cqc committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    1d575e5 View commit details
    Browse the repository at this point in the history

  3. clippy

    @acl-cqc
    acl-cqc committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    5890873 View commit details
    Browse the repository at this point in the history

  4. fmt after clippy!

    @acl-cqc
    acl-cqc committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    b359731 View commit details
    Browse the repository at this point in the history

  5. Update doc comment, don't mention closure

    @acl-cqc
    acl-cqc committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    4fcb72f View commit details
    Browse the repository at this point in the history

  6. instantiate_extensions: take &ExtensionSolution

    @acl-cqc
    acl-cqc committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    2390102 View commit details
    Browse the repository at this point in the history

  7. Revert unnecessary test changes

    @acl-cqc
    acl-cqc committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    5d0ffd3 View commit details
    Browse the repository at this point in the history

  8. Fix doclink

    @acl-cqc
    acl-cqc committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    777e8e1 View commit details
    Browse the repository at this point in the history

  9. Add separate test of validate_with_extension_closure

    @acl-cqc
    acl-cqc committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    42a7d05 View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2024

  1. Any clearer?

    @acl-cqc
    acl-cqc committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    521314e View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2024

  1. Do more of the test using 'immut'

    @acl-cqc
    acl-cqc committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    0ab3d34 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/main' into refactor/one_extensio… 

    …n_solution
    @acl-cqc
    acl-cqc committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    c04c609 View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2024

  1. WIP extended test. Fails as I/O nodes not added

    @acl-cqc
    acl-cqc committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    a575aeb View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2024

  1. Fix test using builder

    @acl-cqc
    acl-cqc committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    58b312b View commit details
    Browse the repository at this point in the history

  2. Move imports out

    @acl-cqc
    acl-cqc committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    56a4ad1 View commit details
    Browse the repository at this point in the history

  3. No need to lift, drop EXTENSION_ID, tidies

    @acl-cqc
    acl-cqc committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    2becf67 View commit details
    Browse the repository at this point in the history

  4. rewrite test w/closed_dfg_root hugr; fix: infer_extensions returns on… 

    …ly NEW results
    @acl-cqc
    acl-cqc committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    21db3a6 View commit details
    Browse the repository at this point in the history

  5. common up via helpers

    @acl-cqc
    acl-cqc committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    e39e325 View commit details
    Browse the repository at this point in the history

  6. Rename, avoid a clone

    @acl-cqc
    acl-cqc committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    7607a9a View commit details
    Browse the repository at this point in the history

  7. Merge remote-tracking branch 'origin/main' into refactor/one_extensio… 

    …n_solution
    @acl-cqc
    acl-cqc committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    178f9c8 View commit details
    Browse the repository at this point in the history